Fix ERR test. #604
Fix ERR test. #604
Conversation
|
@briandobbins @billsacks since Jim is out this week, can either one of you review this PR. Thanks |
|
@fischer-ncar - can you explain this change? In your description, you say, "Need to write restarts at the end of the run for ERR tests." But my understanding of the code change is that it does the opposite - i.e., skips writing restart files at the end of the run. Can you clarify the intent of the change, and also why this change is needed? I also want to confirm that this isn't circumventing some aspect of the robustness of this test - e.g., the robustness added by @jedwards4b in ESMCI/cime#4829: I'm wondering if what's really needed is a fix to some logic. I want to clarify that I don't understand the intent of this test well enough to know one way or the other, but just want to better understand the rationale / justification for this change before approving. |
|
@billsacks You're correct, I had the logic reversed in my head. I've updated the description for a better explanation of what is going on. PR #582 added this line, then PR #597 accidently removed it. |
billsacks
left a comment
billsacks
left a comment
There was a problem hiding this comment.
Thanks for the explanation and pointer to the history, @fischer-ncar !
|
@fischer-ncar - As far as I'm concerned, go ahead and merge whenever you're ready for this to come in. Thanks! |
3 participants
Description of changes
ERR test needs to be added back in here so that the correct history files are copied back for the restart.
This was original added in #582, but accidently removed in #597.
Specific notes
Are changes expected to change answers? bfb
Testing performed
ERR_Ln9.ne16pg3_ne16pg3_mt232.FHISTC_LTso.derecho_intel.cam-outfrq9s_bwic
ERR_Ld5.ne30pg3_t232.B1850C_LTso.derecho_gnu.allactive-defaultio
ERR_Ld7.f10_f10_mg37.IHistClm60BgcCrop.derecho_gnu.clm-default
ERR_Ld7.f10_f10_mg37.IHistClm60BgcCrop.derecho_gnu.drv-interim_restart